[BUGFIX beta] use correct syntax for computed.test.ts #20676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
force-pushed
the
chriskrycho/fix-ts-nightly
branch
from
a07e7ad to
41bb1b0
Compare
|
Since it appears that nightly testing was removed from CI, rather than made optional, the last time the project had TS nightly failures, I ran the same commands locally as the nightly TS build does: $ pnpm add --save-dev typescript@next --workspace-root
$ pnpm run type-check
> ember-source@5.9.0-alpha.1 type-check /Users/chris/dev/emberjs/ember.js
> npm-run-all type-check:*
> ember-source@5.9.0-alpha.1 type-check:internals /Users/chris/dev/emberjs/ember.js
> tsc --noEmit
> ember-source@5.9.0-alpha.1 type-check:types /Users/chris/dev/emberjs/ember.js
> pnpm build:types && tsc --noEmit --project type-tests
> ember-source@5.9.0-alpha.1 build:types /Users/chris/dev/emberjs/ember.js
> node types/publish.mjsThis passed (and it did not before). |
chancancode
approved these changes
Apr 4, 2024
|
Double checked the current snapshot of the decorator spec to be sure, and yeah, the previous syntax shouldn't have been allowed: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this syntax didn’t work before, but possibly it was just a warning. In any case, I believe this should fix the failures with nightly TS runs. cc. @jamescdavis @gitKrystan @wagenet